Fix InMemoryBroker to use startup and shutdown middleware hooks#629
Open
PythonFZ wants to merge 2 commits into
Open
Fix InMemoryBroker to use startup and shutdown middleware hooks#629PythonFZ wants to merge 2 commits into
PythonFZ wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A copy/paste approach + test similar to #358
Instead of relying on
supercalls this PR just copy + pastestaskiq/taskiq/abc/broker.py
Lines 196 to 198 in 9f8db96
and
taskiq/taskiq/abc/broker.py
Lines 217 to 219 in 9f8db96
into the methods of
class InMemoryBroker(AsyncBroker)and adds a simple test case checking ensuringstartupandshutdownwork and the order of execution is correct.