Skip to content

windows: Fix top border overlap#229

Open
3unjee wants to merge 1 commit into
stdware:mainfrom
3unjee:bunjee/ci-windows
Open

windows: Fix top border overlap#229
3unjee wants to merge 1 commit into
stdware:mainfrom
3unjee:bunjee/ci-windows

Conversation

@3unjee
Copy link
Copy Markdown
Contributor

@3unjee 3unjee commented May 19, 2026

This PR fixes a top border overlap on Windows 11 by shifting the content accordingly.

NOTE: The issue can be tested from the main branch by adding a border of 1 pixel at the top of the QML window example, it gets hidden.

@3unjee 3unjee force-pushed the bunjee/ci-windows branch from e393150 to 7766054 Compare May 19, 2026 15:41
@wangwenx190 wangwenx190 self-requested a review May 25, 2026 08:38
@wangwenx190 wangwenx190 self-assigned this May 25, 2026
wangwenx190
wangwenx190 requested changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@wangwenx190 wangwenx190 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Only some minor issues

Comment thread src/core/contexts/win32windowcontext.cpp Outdated
Comment thread src/core/contexts/win32windowcontext.cpp Outdated
Comment thread src/core/contexts/win32windowcontext.cpp Outdated
Comment thread src/core/contexts/win32windowcontext.cpp Outdated
@wangwenx190
Copy link
Copy Markdown
Collaborator

wangwenx190 commented May 25, 2026

Sorry for the late review. I've been to hospital last week and have no access to PC/network ...

@3unjee
Copy link
Copy Markdown
Contributor Author

3unjee commented May 26, 2026

Sorry for the late review. I've been to hospital last week and have no access to PC/network ...

No problem sir. I hope everything is fine now

@3unjee 3unjee force-pushed the bunjee/ci-windows branch from 7766054 to 49bb413 Compare May 26, 2026 08:04
@wangwenx190
Copy link
Copy Markdown
Collaborator

wangwenx190 commented May 26, 2026

Thanks! only some minor questions left. And have you tested this PR on different DPIs? Will something be broken if you drag the window between two monitors with different DPI and resolution?

@3unjee
Copy link
Copy Markdown
Contributor Author

3unjee commented May 26, 2026

Thanks! only some minor questions left. And have you tested this PR on different DPIs? Will something be broken if you drag the window between two monitors with different DPI and resolution?

Yes I've tested, getWindowFrameBorderThickness should handle it.

@3unjee
Copy link
Copy Markdown
Contributor Author

3unjee commented May 27, 2026 •
edited
Loading

After some testing, the fix apparently causes some issue on Windows10

EDIT: the patch is now Windows 11 only.

@3unjee 3unjee force-pushed the bunjee/ci-windows branch from 49bb413 to 908a7f4 Compare May 27, 2026 09:52
@3unjee 3unjee requested a review from wangwenx190 May 27, 2026 09:54
@wangwenx190
Copy link
Copy Markdown
Collaborator

wangwenx190 commented May 27, 2026

But why only works on Win11? Win10 has a top border as well, can't this PR also fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangwenx190 wangwenx190 Awaiting requested review from wangwenx190

Assignees

@wangwenx190 wangwenx190

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@3unjee @wangwenx190