Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, build tools, and SDK versions across the project, including upgrading Gradle, AGP, and targeting Android SDK 37. It also replaces SpatialLayoutSpacer with SpatialSpacer in the XR feature module. Feedback focuses on two main issues: first, targeting Android SDK 37 and Build Tools 37.0.0 is premature as they are not yet available, which will cause build failures across the build scripts and settings; second, the newly added androidx-compose-foundation dependency should omit an explicit version and instead rely on the Compose BOM to manage its version, making the explicit foundation version variable redundant.
| androidx-camera-compose = { module = "androidx.camera:camera-compose", version.ref = "camerax" } | ||
| androidx-camera-core = { module = "androidx.camera:camera-core", version.ref = "camerax" } | ||
| androidx-camera-lifecycle = { group = "androidx.camera", name = "camera-lifecycle", version.ref = "camerax" } | ||
| androidx-compose-foundation = { group = "androidx.compose.foundation", name = "foundation", version.ref = "foundation" } |
There was a problem hiding this comment.
Since this project uses the Compose BOM (androidx-compose-bom), individual Compose libraries like foundation should not specify an explicit version. Instead, they should rely on the BOM to manage and align their versions. This prevents potential version mismatches and dependency resolution issues.
| androidx-compose-foundation = { group = "androidx.compose.foundation", name = "foundation", version.ref = "foundation" } | |
| androidx-compose-foundation = { group = "androidx.compose.foundation", name = "foundation" } |
| ANDROID_SDK_VERSION="37" | ||
| ANDROID_BUILD_TOOLS_VERSION="37.0.0" |
There was a problem hiding this comment.
Android SDK version 37 and Build Tools version 37.0.0 are not yet released or available in the Android SDK repository. Running sdkmanager with these versions will fail, causing the build script to exit with an error. Please verify if you meant SDK version 36 (Android 16) or if this was bumped prematurely.
| ANDROID_SDK_VERSION="37" | |
| ANDROID_BUILD_TOOLS_VERSION="37.0.0" | |
| ANDROID_SDK_VERSION="36" | |
| ANDROID_BUILD_TOOLS_VERSION="36.0.0" |
| ANDROID_SDK_VERSION="37" | ||
| ANDROID_BUILD_TOOLS_VERSION="37.0.0" |
There was a problem hiding this comment.
Android SDK version 37 and Build Tools version 37.0.0 are not yet released or available in the Android SDK repository. Running sdkmanager with these versions will fail, causing the build script to exit with an error. Please verify if you meant SDK version 36 (Android 16) or if this was bumped prematurely.
| ANDROID_SDK_VERSION="37" | |
| ANDROID_BUILD_TOOLS_VERSION="37.0.0" | |
| ANDROID_SDK_VERSION="36" | |
| ANDROID_BUILD_TOOLS_VERSION="36.0.0" |
| ANDROID_SDK_VERSION="37" | ||
| ANDROID_BUILD_TOOLS_VERSION="37.0.0" |
There was a problem hiding this comment.
Android SDK version 37 and Build Tools version 37.0.0 are not yet released or available in the Android SDK repository. Running sdkmanager with these versions will fail, causing the build script to exit with an error. Please verify if you meant SDK version 36 (Android 16) or if this was bumped prematurely.
| ANDROID_SDK_VERSION="37" | |
| ANDROID_BUILD_TOOLS_VERSION="37.0.0" | |
| ANDROID_SDK_VERSION="36" | |
| ANDROID_BUILD_TOOLS_VERSION="36.0.0" |
| ANDROID_SDK_VERSION="37" | ||
| ANDROID_BUILD_TOOLS_VERSION="37.0.0" |
There was a problem hiding this comment.
Android SDK version 37 and Build Tools version 37.0.0 are not yet released or available in the Android SDK repository. Running sdkmanager with these versions will fail, causing the build script to exit with an error. Please verify if you meant SDK version 36 (Android 16) or if this was bumped prematurely.
| ANDROID_SDK_VERSION="37" | |
| ANDROID_BUILD_TOOLS_VERSION="37.0.0" | |
| ANDROID_SDK_VERSION="36" | |
| ANDROID_BUILD_TOOLS_VERSION="36.0.0" |
| compileSdk { | ||
| version = release(36) | ||
| version = release(37) | ||
| } | ||
| targetSdk { | ||
| version = release(36) | ||
| version = release(37) | ||
| } |
There was a problem hiding this comment.
Compiling and targeting Android SDK 37 is premature as it is not yet released or available. This will cause build failures. Please revert to SDK 36 (Android 16) or the appropriate available version.
compileSdk {
version = release(36)
}
targetSdk {
version = release(36)
}| firebaseBom = "34.13.0" | ||
| foundation = "1.12.0-alpha03" | ||
| genaiPrompt = "1.0.0-beta2" |
There was a problem hiding this comment.
Since androidx-compose-foundation should be managed by the Compose BOM (androidx-compose-bom), the explicit foundation version variable is redundant and can be removed.
| firebaseBom = "34.13.0" | |
| foundation = "1.12.0-alpha03" | |
| genaiPrompt = "1.0.0-beta2" | |
| firebaseBom = "34.13.0" | |
| genaiPrompt = "1.0.0-beta2" |
1 participant
No description provided.