fix(macos): always show dock icon setting now works during recording

[ManthanNimodiya]

Summary

The "Always show dock icon" in the setting had no effect, the dock icon would still disappear when recording started regardless of the toggle.

A previous fix (preventing duplicate dock icons) added a bail-early in sync_macos_dock_visibility that ran before reading the user's preference, so the sync was unconditionally skipped whenever recording was active.
The toggle existed but did nothing.

The fix reads the hide_dock_icon setting first, then only bails when the user actually wants the dock hidden.
If the setting is off (always show), the sync continues and keeps the dock icon visible throughout the recording.

Fixes #1843

Changes

• apps/desktop/src-tauri/src/permissions.rs: read hide_dock_icon before the panel window guard; only bail when both conditions are true

Test Plan

• Enable "Always show dock icon" → start recording → dock icon stays visible throughout
• Disable "Always show dock icon" → start recording → dock icon hides as expected

Greptile Summary

This PR fixes a bug where the "Always show dock icon" setting had no effect during recording on macOS. A prior guard that prevented duplicate dock icons used an unconditional early return whenever a panel window was visible, which ran before the user's hide_dock_icon preference was ever read.

• The should_hide_dock value is now fetched before the panel-window check, and the early return is conditioned on has_visible_panel_window && should_hide_dock — so recording no longer forces the dock to hide when the user has opted to always show it.
• When "Always show dock icon" is disabled the behavior is unchanged: the function still bails early during recording, preserving the original duplicate-icon fix.

Confidence Score: 5/5

Safe to merge — single-file, minimal logic change that correctly restores the dock icon when the user prefers it visible.

The change is surgical: one variable read is moved earlier and one boolean condition is added to the guard. Both branches of the user preference (hide vs. show dock) were manually tested per the test plan, the duplicate-dock-icon fix is preserved when should_hide_dock is true, and there are no side-effects on unrelated code paths.

No files require special attention.

Important Files Changed

Filename	Overview
apps/desktop/src-tauri/src/permissions.rs	Moves should_hide_dock read before the panel-window bail-early guard and gates the early return on both conditions, fixing dock visibility when "Always show dock icon" is enabled during recording.

_{Reviews (1): Last reviewed commit: "fix(macos): respect hide_dock_icon setti..." | Re-trigger Greptile}

[ManthanNimodiya]

hey @richiemcilroy , please have a review and lmk for any changes