Add details about merging pull requests#1808
Merged
Merged
Conversation
Documentation build overview
4 files changed± index.html± core-team/index.html± versions/index.html± core-team/committing/index.html |
Mariatta
reviewed
May 23, 2026
Mariatta
reviewed
May 23, 2026
hugovk
approved these changes
May 23, 2026
| Completing the pull request | ||
| --------------------------- | ||
|
|
||
| Once the pull request is ready, you (the core team member) bring it into main. |
Member
There was a problem hiding this comment.
Perhaps
Suggested change
| Once the pull request is ready, you (the core team member) bring it into main. | |
| Once the pull request is ready, you (the core team member) merge it into main. |
Member
Author
|
Thanks everyone, sorry for the misspellings! I was avoiding "merge" because it's actually a squash, but I think you are right the avoidance makes for awkward wordings. |
Member
Technically, it's a squash and merge ;-) 
Regular contributors can do squashes (which we don't like), but they can't merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a discord discussion where I needed help knowing the steps and expectations: https://discord.com/channels/854719841091715092/854721045264203836/1507343600655269938