Fail on conflicting TestingPlatformBuilderHook IDs#8508
Open
Copilot wants to merge 3 commits into
Open
Conversation
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix silent dropping of duplicate TestingPlatformBuilderHook IDs
Fail on conflicting TestingPlatformBuilderHook IDs
May 22, 2026
Member
|
/review |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens TestingPlatformSelfRegisteredExtensions (MSBuild task) by validating TestingPlatformBuilderHook items for duplicate IDs: exact duplicates are deduplicated, while conflicting duplicates now fail the build to avoid silently dropping an extension.
Changes:
- Added validation + deduplication for
SelfRegisteredExtensionsBuilderHookitems, failing on conflicting metadata for the same Include/ID. - Updated code generation to use the validated, deduplicated hook set.
- Added unit tests covering exact-duplicate deduplication and conflicting-duplicate failure behavior.
Show a summary per file
| File | Description |
|---|---|
| test/UnitTests/Microsoft.Testing.Platform.MSBuild.UnitTests/MSBuildTests.cs | Adds unit coverage for deduplication and for build failure when duplicate hook IDs have conflicting metadata. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/TestingPlatformAutoRegisteredExtensions.cs | Implements hook validation/deduplication and wires code generation to the validated hook list. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
| Assert.IsTrue(selfRegisteredExtensions.Execute()); | ||
|
|
||
| string generatedSource = inMemoryFileSystem.Files["obj/selfRegisteredExtensionsFile"]!; | ||
| Assert.HasCount(1, Regex.Matches(generatedSource, "global::Contoso.Hook.AddExtensions")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestingPlatformSelfRegisteredExtensionspreviously collapsed duplicateTestingPlatformBuilderHookitems by ID and kept the first entry. If two packages reused an ID with different metadata, one extension disappeared silently.Duplicate validation
DisplayNameorTypeFullName.Exact duplicate handling
Regression coverage
The above now fails the build instead of silently registering only the first hook.