Skip to content

[UI] Fix blog card thumbnail alignment in list viewfix: improve blog card thumbnail alignment in list view#7745

Closed
Saanvim11 wants to merge 5 commits into
layer5io:masterfrom
Saanvim11:fix-blog-thumbnail-alignment
Closed

[UI] Fix blog card thumbnail alignment in list viewfix: improve blog card thumbnail alignment in list view#7745
Saanvim11 wants to merge 5 commits into
layer5io:masterfrom
Saanvim11:fix-blog-thumbnail-alignment

Conversation

@Saanvim11
Copy link
Copy Markdown
Contributor

@Saanvim11 Saanvim11 commented May 21, 2026

Description

This PR fixes inconsistent blog card thumbnail alignment in list view.

Changes

  • Replaced object-fit: contain with object-fit: cover
  • Updated image sizing to ensure thumbnails fill their containers consistently
  • Removed uneven spacing caused by varying image aspect ratios

This addresses the layout inconsistency discussed in #7743.

@rishiraj38 rishiraj38 added the issue/dco Commit sign-off instructions label May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

rishiraj38
rishiraj38 reviewed May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saanvim11 The DCO check is failing. Also, we already have a prop specifically handling the list view, so why are we adding object-fit properties again here?

I believe these changes might end up affecting the grid view as well.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026 •
edited
Loading

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-05-24 19:27 UTC

@Saanvim11 Saanvim11 closed this May 21, 2026
@Saanvim11 Saanvim11 reopened this May 21, 2026
@rishiraj38
Copy link
Copy Markdown
Member

rishiraj38 commented May 21, 2026

@Saanvim11 Please make a signed commit using git commit -s -m.

rishiraj38
rishiraj38 suggested changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the changes requested.

Comment thread src/components/Card/Card.style.js Outdated
Comment thread src/components/Card/Card.style.js Outdated
Comment thread src/components/Card/Card.style.js
Comment thread src/components/Card/Card.style.js
Comment thread src/components/Card/Card.style.js
Comment thread src/components/Card/Card.style.js Outdated
Comment thread src/components/Card/Card.style.js
Comment thread src/components/Card/Card.style.js Outdated
@rishiraj38
Copy link
Copy Markdown
Member

rishiraj38 commented May 22, 2026

@saurabhraghuvanshii @Rajesh-Nagarajan-11 Please take a look. Apart from the DCO, everything else looks good to me.

@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member

Rajesh-Nagarajan-11 commented May 22, 2026

@Saanvim11 Kindly sign off your commits please

@rishiraj38
Copy link
Copy Markdown
Member

rishiraj38 commented May 23, 2026

@Saanvim11, are you active? Any updates?

@Katotodan
Copy link
Copy Markdown
Member

Katotodan commented May 23, 2026

@Saanvim11
Please follow these instructions to sign off you commit

  • In your local branch, run: git rebase HEAD~4 --signoff
  • Force push your changes to overwrite the branch: git push --force-with-lease origin fix-blog-thumbnail-alignment

leecalcote and others added 5 commits May 24, 2026 15:04
@leecalcote @Saanvim11
Bump sistent v0.21.11 dependencies
28e8e49 
Signed-off-by: leecalcote <leecalcote@users.noreply.github.com>
Signed-off-by: Saanvim11 <saanvimoolchandani01@gmail.com>
@Daniel-1600 @Saanvim11
chore: update sistent to v0.21.11 and add missing @rjsf peer deps
0ddd6d6 
Signed-off-by: Daniel Mungai <chegedan699@gmail.com>
Signed-off-by: Saanvim11 <saanvimoolchandani01@gmail.com>
@meshery-ci @Saanvim11
[Docs] Generated documentation for Integration
0f2a78e 
Signed-off-by: l5io <ci@meshery.io>
Signed-off-by: Saanvim11 <saanvimoolchandani01@gmail.com>
@Saanvim11
fix: improve blog card thumbnail alignment in list view
bb23d26 
Signed-off-by: Saanvim11 <saanvimoolchandani01@gmail.com>
@Saanvim11
refactor: Improve blog card image alignment - address review feedback…
93752e9 
…- Remove conflicting margin-left on images in list view- Add overflow: hidden to prevent image overflow - Add flex-shrink: 0 to maintain container dimensions- Apply object-fit: cover consistently across all breakpoints- Set display: block to remove inline spacing issues- Simplify Card.style.js by removing redundant CSS

Signed-off-by: Saanvim11 <saanvimoolchandani01@gmail.com>
@Saanvim11 Saanvim11 force-pushed the fix-blog-thumbnail-alignment branch from 887f90b to 93752e9 Compare May 24, 2026 09:37
@Bhumikagarggg
Copy link
Copy Markdown
Contributor

Bhumikagarggg commented May 24, 2026

@Saanvim11 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@saurabhraghuvanshii
Copy link
Copy Markdown
Member

saurabhraghuvanshii commented May 24, 2026

@Saanvim11 I would suggest you to open new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rishiraj38 rishiraj38 rishiraj38 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

issue/dco Commit sign-off instructions project/meshery

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Saanvim11 @rishiraj38 @Rajesh-Nagarajan-11 @Katotodan @Bhumikagarggg @saurabhraghuvanshii @leecalcote @Daniel-1600 @meshery-ci