Conversation
…very subprocess init() starts a short-lived Julia process solely to print libjulia's path and Sys.BINDIR. In pre-built containers / system images these are static and known ahead of time; allow supplying them via the libpath / default_bindir options (PYTHON_JULIACALL_LIBPATH / PYTHON_JULIACALL_DEFAULT_BINDIR) to skip the extra process. Behaviour is unchanged unless both are set. Docs and CHANGELOG updated.
…of libpath, exepath and bindir depending on if others are set
Member
Author
|
@ncudlenco You didn't allow permission for me to modify your PR so i've made this other branch. I reworked the logic - see the PR description above. So now you only need to set |
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative version of #774.
In this version we just add one new option
liband re-use the existingbindiroption.We have sensible discovery/defaults:
exeis not set butbindiris, then setexe={bindir}/julia.libis not set, then launch a julia subprocess (as we did unconditionally before) to find it. Also findbindirif not set.bindiris not set, then set it to the directory containingexe.Hence setting
exe(orbindir) andlibis sufficient to avoid the julia subprocess.